Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration check for keepoutputdirectory in cleanup #748

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix configuration check for keepoutputdirectory in cleanup #748

merged 1 commit into from
Apr 6, 2021

Conversation

daryl-c
Copy link
Contributor

@daryl-c daryl-c commented Mar 28, 2021

What did you implement:

Closes #747

Appears to be that the cleanup function no longer checks the configuration, only this.keepOutputDirectory which appears to be a flag set by other processes

How did you implement it:

I added a check for the configuration passing a keepOutputDirectory flag as well in the cleanup module.

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@daryl-c
Copy link
Contributor Author

daryl-c commented Mar 28, 2021

Just a note, I've not made a PR to open source before so please let me know if I've done anything incorrectly. Thanks!

Copy link

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this same problem today, and it would be great to merge this. Thanks!

Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j0k3r
Copy link
Member

j0k3r commented Apr 6, 2021

I just force pushed so the branch will be up-to-date with the master and I'll be able to merge it

@j0k3r j0k3r added this to the 5.4.1 milestone Apr 6, 2021
@j0k3r j0k3r merged commit ac82119 into serverless-heaven:master Apr 6, 2021
@daryl-c
Copy link
Contributor Author

daryl-c commented Apr 6, 2021

Thanks for letting me get involved @j0k3r!

@j0k3r
Copy link
Member

j0k3r commented Apr 6, 2021

Good job for your first clean PR 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output directory is deleted when keepOutputDirectory is true
3 participants