Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run webpack on a single non-node function #879

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Jun 14, 2021

Should fix #755

@j0k3r j0k3r force-pushed the fix/skip-single-non-node-function branch from 817dc53 to b87a65c Compare June 14, 2021 09:25
@j0k3r j0k3r added this to the 5.5.2 milestone Jun 14, 2021
@j0k3r j0k3r force-pushed the fix/skip-single-non-node-function branch from b87a65c to 650e30f Compare June 29, 2021 12:05
@j0k3r
Copy link
Member Author

j0k3r commented Jun 29, 2021

@miguel-a-calles-mba can you check that? 🙏

Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tome.

@j0k3r j0k3r force-pushed the fix/skip-single-non-node-function branch from 2570230 to 688211a Compare August 25, 2021 07:59
@j0k3r j0k3r merged commit 509b74f into master Aug 25, 2021
@j0k3r j0k3r deleted the fix/skip-single-non-node-function branch August 25, 2021 08:02
@oduncan
Copy link

oduncan commented Aug 31, 2021

Is there a way to force webpack to run when running sls deploy function -f myfunctionname? because that's how I was pushing incremental changes "quickly" and testing my graphql server. Or is there a better way to accomplish this.

@miguel-a-calles-mba
Copy link
Member

@oduncan, you should be able to run sls package before running the single function deploy to package the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom runtime not workig for deployment of single function
3 participants