Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simple string images #961

Merged
merged 4 commits into from Oct 7, 2021
Merged

Allow simple string images #961

merged 4 commits into from Oct 7, 2021

Conversation

gwdp
Copy link
Contributor

@gwdp gwdp commented Sep 20, 2021

What did you implement:

Amend fixes on #825

Issue introduced with image command detection implemented on recent versions, preventing simple remote images to be used when in usage with this plugin.
Serverless documentation also indicates its support. (Please, scroll to the very bottom, the last example) https://www.serverless.com/blog/container-support-for-lambda

How did you implement it:

Prevent inclusion of the 'image' into webpack entries, and also detect the image string before checking for the image name.

How can we verify it:

service: report-support
provider:
  name: aws
  region: ca-central-1
  runtime: nodejs12.x
  stage: ${opt:stage, 'dev'}
  versionFunctions: false
plugins:
  - serverless-webpack
functions:
  server:
    image: public.ecr.aws/lambda/nodejs:latest
custom:
  webpack:
    webpackConfig: api/webpack.config.js
    packager: yarn
    keepOutputDirectory: true

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@vicary
Copy link
Member

vicary commented Sep 30, 2021

@gwdp please rebase after #967 to fix the failing test.

@gwdp
Copy link
Contributor Author

gwdp commented Oct 6, 2021

@vicary Could you check now please?

Copy link
Member

@vicary vicary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vicary vicary merged commit 036757e into serverless-heaven:master Oct 7, 2021
@j0k3r j0k3r added this to the 5.5.5 milestone Oct 15, 2021
@j0k3r j0k3r mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants