fix(serverless-component): when adding primary domain name to CloudFr…

…ont distribution aliases, don't replace other aliases (#658)
serverless-nextjs · Oct 7, 2020 · 4428d5c · 4428d5c
1 parent 1f2d153
commit 4428d5c
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/packages/serverless-components/domain/utils.js b/packages/serverless-components/domain/utils.js
@@ -393,21 +393,19 @@ const addDomainToCloudfrontDistribution = async (
   params.Id = subdomain.distributionId;
 
   // 5. then make our changes
-  params.DistributionConfig.Aliases = {
-    Quantity: 1,
-    Items: [subdomain.domain]
-  };
-
+  params.DistributionConfig.Aliases.Items.push(subdomain.domain);
+  params.DistributionConfig.Aliases.Quantity += 1;
   if (subdomain.domain.startsWith("www.")) {
     if (domainType === "apex") {
-      params.DistributionConfig.Aliases.Items = [
-        `${subdomain.domain.replace("www.", "")}`
-      ];
+      params.DistributionConfig.Aliases.Items[-1] = `${subdomain.domain.replace(
+        "www.",
+        ""
+      )}`;
     } else if (domainType !== "www") {
-      params.DistributionConfig.Aliases.Quantity = 2;
       params.DistributionConfig.Aliases.Items.push(
         `${subdomain.domain.replace("www.", "")}`
       );
+      params.DistributionConfig.Aliases.Quantity += 1;
     }
   }