Skip to content

Commit

Permalink
fix(domain): add missing pieces to 'domainMinimumProtocolVersion' inp…
Browse files Browse the repository at this point in the history
…ut use (#1983)

Co-authored-by: ari.luokkala <ari.luokkala@sok.fi>
  • Loading branch information
ari-luokkala and ari.luokkala committed Oct 29, 2021
1 parent 7682e13 commit dff22ba
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/serverless-components/domain/src/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default class Domain extends Component {
}

if (!isMinimumProtocolVersionValid(inputs.domainMinimumProtocolVersion)) {
throw Error('"minimumProtocolVersion" has in invalid value.');
throw Error('"minimumProtocolVersion" has invalid value.');
}

// TODO: Check if domain has changed.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,8 @@ class NextjsComponent extends Component {
},
domainType: inputs.domainType || "both",
defaultCloudfrontInputs: cloudFrontDefaults,
certificateArn: inputs.certificateArn
certificateArn: inputs.certificateArn,
domainMinimumProtocolVersion: inputs.domainMinimumProtocolVersion
});
appUrl = domainOutputs.domains[0];
}
Expand Down
1 change: 1 addition & 0 deletions packages/serverless-components/nextjs-component/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export type ServerlessComponentInputs = {
domain?: string | string[];
domainType?: "www" | "apex" | "both";
domainRedirects?: { [key: string]: string };
domainMinimumProtocolVersion?: string;
cloudfront?: CloudfrontOptions;
minifyHandlers?: boolean;
uploadStaticAssetsFromBuild?: boolean;
Expand Down

0 comments on commit dff22ba

Please sign in to comment.