Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(domain): add missing pieces to 'domainMinimumProtocolVersion' inp… #1983

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

ari-luokkala
Copy link
Contributor

…ut use

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 7682e13)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1497,
            "Minified": 659
        },
        "Image Lambda": {
            "Standard": 1463,
            "Minified": 793
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1508,
            "Minified": 665
        },
        "Default Lambda V2": {
            "Standard": 1500,
            "Minified": 662
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1472,
            "Minified": 798
        },
        "Regeneration Lambda": {
            "Standard": 1164,
            "Minified": 538
        },
        "Regeneration Lambda V2": {
            "Standard": 1230,
            "Minified": 565
        }
    }
}

New Handler Sizes (kB) (commit fba910d)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1497,
            "Minified": 659
        },
        "Image Lambda": {
            "Standard": 1463,
            "Minified": 793
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1508,
            "Minified": 665
        },
        "Default Lambda V2": {
            "Standard": 1500,
            "Minified": 662
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1472,
            "Minified": 798
        },
        "Regeneration Lambda": {
            "Standard": 1164,
            "Minified": 538
        },
        "Regeneration Lambda V2": {
            "Standard": 1230,
            "Minified": 565
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1983 (fba910d) into master (ec19109) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
+ Coverage   83.81%   83.85%   +0.03%     
==========================================
  Files         101      102       +1     
  Lines        3608     3623      +15     
  Branches     1140     1142       +2     
==========================================
+ Hits         3024     3038      +14     
- Misses        572      573       +1     
  Partials       12       12              
Impacted Files Coverage Δ
...ages/serverless-components/domain/src/component.ts 0.00% <0.00%> (ø)
...rless-components/nextjs-component/src/component.ts 86.36% <ø> (ø)
...erless-components/aws-lambda/src/waitUntilReady.ts 92.85% <0.00%> (ø)
.../serverless-components/aws-lambda/src/component.ts 71.01% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec19109...fba910d. Read the comment docs.

@dphang dphang merged commit dff22ba into serverless-nextjs:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants