Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass certificateArn to domain component #826

Merged
merged 3 commits into from Dec 2, 2020

Conversation

huksley
Copy link
Contributor

@huksley huksley commented Dec 1, 2020

Currently, declared on README.md page certificateArn does not passed to domain component, resulting in searching for domain certificate, which works bad for subdomains, i.e. app.example.com

See issue here: #821

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #826 (603e250) into master (f63bc76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files          57       57           
  Lines        1936     1936           
  Branches      434      434           
=======================================
  Hits         1562     1562           
  Misses        314      314           
  Partials       60       60           
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 90.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63bc76...603e250. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Dec 2, 2020

Thanks, since domain component doesn't have any test coverage yet, please test the change if it is working fine, then can merge it.

@huksley
Copy link
Contributor Author

huksley commented Dec 2, 2020

@dphang Would you like me to write a test on it? I am currently deploying it to my infra and it is working.

@dphang
Copy link
Collaborator

dphang commented Dec 2, 2020

If you have time and it's simple that'd be great (there is an issue for this: #690), but we may move away from it in the future (looking into more robust IaC tools like CDK). But we can merge this one first. Thanks!

@dphang
Copy link
Collaborator

dphang commented Dec 2, 2020

@dphang dphang merged commit b7cf083 into serverless-nextjs:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants