Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass certificateArn to domain component #826

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Pass certificateArn to domain component #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5d297f
fix: pass certificateArn to domain component
huksley Dec 1, 2020
888b286
Return back previous formatting
huksley Dec 1, 2020
603e250
Merge branch 'master' into domain-certificateArn
dphang Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/serverless-components/nextjs-component/src/component.ts
View file
Open in desktop
Expand Up @@ -655,7 +655,8 @@ class NextjsComponent extends Component {
[subdomain]: cloudFrontOutputs
},
domainType: inputs.domainType || "both",
defaultCloudfrontInputs: cloudFrontDefaults
defaultCloudfrontInputs: cloudFrontDefaults,
certificateArn: inputs.certificateArn
});
appUrl = domainOutputs.domains[0];
}
Expand Down
1 change: 1 addition & 0 deletions packages/serverless-components/nextjs-component/types.d.ts
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@ export type ServerlessComponentInputs = {
deploy?: boolean;
enableHTTPCompression?: boolean;
authentication?: { username: string; password: string };
certificateArn?: string;
};

type CloudfrontOptions = Record<string, any>;
Expand Down