Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Experimental Next.js 12 Output File Tracing (#2169)" #2324

Merged

Conversation

iiroj
Copy link
Contributor

@iiroj iiroj commented Jan 29, 2022

This reverts commit e01571f.

See #2323 (comment), it looks like taking advantage of the output file tracing won't be as trivial as I thought, so let's revert the current implementation to not have it block other updates to this fantastic library!

Sorry about the hassle; I'll be back with a better-working solution.

@iiroj
Copy link
Contributor Author

iiroj commented Jan 29, 2022

@dphang for your information.

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 9facd15)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit 3d1a842)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1524,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1488,
            "Minified": 800
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 673
        },
        "Default Lambda V2": {
            "Standard": 1526,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1496,
            "Minified": 805
        },
        "Regeneration Lambda": {
            "Standard": 1187,
            "Minified": 546
        },
        "Regeneration Lambda V2": {
            "Standard": 1253,
            "Minified": 573
        }
    }
}

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #2324 (3d1a842) into master (9facd15) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2324      +/-   ##
==========================================
- Coverage   83.63%   83.56%   -0.08%     
==========================================
  Files         104      102       -2     
  Lines        3716     3674      -42     
  Branches     1194     1172      -22     
==========================================
- Hits         3108     3070      -38     
+ Misses        596      592       -4     
  Partials       12       12              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 96.07% <100.00%> (+3.11%) ⬆️
...rless-components/nextjs-component/src/component.ts 86.36% <100.00%> (-1.88%) ⬇️
...ponents/nextjs-component/__tests__/aws-sdk.mock.ts 91.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9facd15...3d1a842. Read the comment docs.

@dphang dphang merged commit ca7f7f7 into serverless-nextjs:master Jan 31, 2022
@iiroj iiroj deleted the revert-output-file-tracing branch January 31, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants