Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticSite]: Please make 'deployId' public #1099

Closed
iDVB opened this issue Dec 1, 2021 · 0 comments · Fixed by #1104
Closed

[StaticSite]: Please make 'deployId' public #1099

iDVB opened this issue Dec 1, 2021 · 0 comments · Fixed by #1104
Assignees
Projects

Comments

@iDVB
Copy link
Contributor

iDVB commented Dec 1, 2021

Currently, StaticSite makes this.deployId private.

However, is it was made public, people could pass this value into other constructs that need to know which bucket key/directory is the public/deployed one.

Eg. We have a Lambda@Edge that processes a file in the root of the deploy bucket (usually the root) called _redirects. Since StaticSite moves this down into a dynamic key deploy-[hash] it has rendered our router inoperable.

WithdeployId we plan to create a custom CF header that can pass this value into our edge function which will fix the issue.

@thdxr thdxr self-assigned this Dec 1, 2021
@thdxr thdxr added this to Todo in Roadmap via automation Dec 1, 2021
@thdxr thdxr moved this from Todo to In Progress in Roadmap Dec 1, 2021
@thdxr thdxr moved this from In Progress to Shipped in Roadmap Dec 1, 2021
@thdxr thdxr moved this from Shipped to In Progress in Roadmap Dec 1, 2021
Roadmap automation moved this from In Progress to Shipped Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Roadmap
Shipped
Development

Successfully merging a pull request may close this issue.

2 participants