Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added external custom domain support to Api construct #1138

Merged
merged 7 commits into from Jan 16, 2022
Merged

added external custom domain support to Api construct #1138

merged 7 commits into from Jan 16, 2022

Conversation

Manitej66
Copy link
Contributor

Added support for adding custom domains to the Api construct that are outside of Route 53.

Sample code example:

const api = new sst.Api(this, "Api", {
  customDomain: {
    domainName: "api.sst.sh",
    isExternalDomain: true,
    certificate: acm.Certificate.fromCertificateArn(
      this,
      "Certificate",
      "arn:aws:acm:us-east-1:000639264671:certificate/xxxx"
    ),
  },
  routes: {
    "GET /": "src/lambda.main",
  },
});

@Manitej66 Manitej66 added enhancement New feature or request pkg: resources/Api labels Dec 10, 2021
@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for sst-console canceled.

🔨 Explore the source changes: 8f1c92f

🔍 Inspect the deploy log: https://app.netlify.com/sites/sst-console/deploys/61e345c0c89e8e000816aae8

@fwang fwang linked an issue Jan 15, 2022 that may be closed by this pull request
@fwang fwang merged commit 10126d8 into sst:master Jan 16, 2022
@JonHolman
Copy link

Thank you @Manitej66 and @fwang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api: support external domains not hosted on Route53
3 participants