Add ViteStaticSite construct #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for sst-console canceled. 🔨 Explore the source changes: c07580c 🔍 Inspect the deploy log: https://app.netlify.com/sites/sst-console/deploys/61f3173430115900085e432f |
fwang
force-pushed
the
vite-static-site
branch
from
2316c8a
to
1065cc6
Compare
fwang
force-pushed
the
vite-static-site
branch
from
fc1c7c7
to
c07580c
Compare
aphex
reviewed
Feb 1, 2022
|
|
||
|
|
||
| ```js title="src/App.js" | ||
| console.log(process.env.VITE_API_URL); |
There was a problem hiding this comment.
@fwang nothing major, but I was just following through this and I think these are supposed to be import.meta.env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.