Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support copyFiles regardless of runtime #636

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Support copyFiles regardless of runtime #636

merged 2 commits into from
Aug 4, 2021

Conversation

thdxr
Copy link
Contributor

@thdxr thdxr commented Aug 3, 2021

Fixes #635

I started to write a test but wasn't sure if there was a recommended way to check what's in ./build for the specific handler

@thdxr thdxr added the enhancement New feature or request label Aug 3, 2021
@thdxr thdxr requested a review from fwang August 3, 2021 15:17
@thdxr thdxr requested a review from fwang August 3, 2021 23:25
@fwang
Copy link
Contributor

fwang commented Aug 4, 2021

I started to write a test but wasn't sure if there was a recommended way to check what's in ./build for the specific handler

We don't have a standard way of checking it. We have an existing test for copyFiles that just calls fs.existsSync to test for specific files.
https://github.com/serverless-stack/serverless-stack/blob/master/packages/cli/test/nodejs-build-bundle-copyfiles/nodejs-build-bundle-copyfiles.test.js

@thdxr thdxr merged commit 0bccd12 into master Aug 4, 2021
@thdxr thdxr deleted the 635 branch August 4, 2021 12:05
radu-c pushed a commit to code11/serverless-stack that referenced this pull request Aug 7, 2021
@thdxr @radu-c
Support copyFiles regardless of runtime (sst#636)
2b7c2f6 
* Support copyFiles regardless of runtime

* Remove log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwang fwang fwang approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support copyFiles regardless of runtime
2 participants
@thdxr @fwang