Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --dir and -d to specify destination directory #716

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jul 17, 2020

What has been implemented?

Closes #714

Steps to verify

  • Run sls help, and note you see both --dir and -d as options
  • run sls init fullstack-app -d my-custom-dir and see that the package is fetched from registry and set up in my-custom-dir
  • run sls init fullstack-app --dir my-custom-dir and see that the package is fetched from registry and set up in my-custom-dir
  • run sls init website -d my-custom-dir and see that the component is initializedin my-custom-dir
  • repeat with an initToken from the dashboard, and note that it works as above.

@astuyve astuyve requested a review from eahefnawy July 17, 2020 18:47
@astuyve astuyve added the kind/enhancement Improvement to something existing label Jul 17, 2020
@eahefnawy
Copy link
Member

Thanks @astuyve ... could you also add this new option to the docs here:
https://github.com/serverless/components#serverless-init-package-name

@astuyve astuyve merged commit 045253f into master Jul 21, 2020
@astuyve astuyve deleted the flag-for-custom-dir branch July 21, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement to something existing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --dir flag for init
2 participants