Switch to new dashboard #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #477 +/- ##
==========================================
- Coverage 53.86% 53.35% -0.52%
==========================================
Files 107 106 -1
Lines 3145 3149 +4
==========================================
- Hits 1694 1680 -14
- Misses 1451 1469 +18
Continue to review full report at Codecov.
|
medikoo
commented
Aug 24, 2020
lib/login.js
Outdated
| @@ -1,24 +1,47 @@ | |||
| 'use strict'; | |||
|
|
|||
| const { login } = require('@serverless/platform-sdk'); | |||
| const { ServerlessSDK } = require('@serverless/platform-client'); | |||
| const { urls, readConfigFile, writeConfigFile, openBrowser } = require('@serverless/platform-sdk'); | |||
There was a problem hiding this comment.
Instead of openBrowser, we should rely on open dependency directly. So we also solve https://github.com/serverless/serverless/issues/7511
They test internal implementation characteristics and not desired outcome, which defeats tests purpose and turns them into an obstacle when refactoring.
medikoo
force-pushed
the
0820-switch-to-new-dashboard
branch
from
76b0042
to
bb95b8b
Compare
medikoo
force-pushed
the
0820-switch-to-new-dashboard
branch
from
bb95b8b
to
603e997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Logging in to new dashboard depends on
@serverless/platform-clientwhich in turn doesn't support Node.js v6. Therefore this cannot be made without introducing a breaking change (at least in context of login/logout functionality)Switch from
dashboard.serverless.comtoapp.serverless.comCloses #474
Fixes #482
Additionally:
process.exitcalls, as they can be error-pronelogin.test.jsas it tested characteristics of implementation and not the desired outcome of implementation. Having that was a real obstacle in refactor