-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new dashboard #477
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #477 +/- ##
==========================================
- Coverage 53.86% 53.35% -0.52%
==========================================
Files 107 106 -1
Lines 3145 3149 +4
==========================================
- Hits 1694 1680 -14
- Misses 1451 1469 +18
Continue to review full report at Codecov.
|
lib/login.js
Outdated
@@ -1,24 +1,47 @@ | |||
'use strict'; | |||
|
|||
const { login } = require('@serverless/platform-sdk'); | |||
const { ServerlessSDK } = require('@serverless/platform-client'); | |||
const { urls, readConfigFile, writeConfigFile, openBrowser } = require('@serverless/platform-sdk'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of openBrowser
, we should rely on open
dependency directly. So we also solve https://github.com/serverless/serverless/issues/7511
They test internal implementation characteristics and not desired outcome, which defeats tests purpose and turns them into an obstacle when refactoring.
76b0042
to
bb95b8b
Compare
bb95b8b
to
603e997
Compare
Note: Logging in to new dashboard depends on
@serverless/platform-client
which in turn doesn't support Node.js v6. Therefore this cannot be made without introducing a breaking change (at least in context of login/logout functionality)Switch from
dashboard.serverless.com
toapp.serverless.com
Closes #474
Fixes #482
Additionally:
process.exit
calls, as they can be error-pronelogin.test.js
as it tested characteristics of implementation and not the desired outcome of implementation. Having that was a real obstacle in refactor