-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate platform-sdk
utils to serverless/utils
tools
#536
Migrate platform-sdk
utils to serverless/utils
tools
#536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 48.84% 49.03% +0.19%
==========================================
Files 90 90
Lines 2891 2896 +5
==========================================
+ Hits 1412 1420 +8
+ Misses 1479 1476 -3
Continue to review full report at Codecov.
|
Sorry, I thought I've sent requests for review 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pgrzesik. Looks excellent! 👍
Just few questions:
- Have integration tests were confirmed to pass?
- Have you tested the interactive CLI onboarding with this changes?
- How many more PR's do you think we need to fully ditch
@serverless/platform-sdk
from this package?
Thank you @medikoo - unfortunately, I didn't run the integration tests locally as I don't have access to
I believe I tested all cases multiple times and confirmed that it's working as intended, I didn't notice any regression or anything after my changes.
I would like to close it with two more - I'm currently working on a PR that introduces a wrapper for getting |
After talking with @medikoo on Slack I was able to successfully run integration tests locally both on |
Looks good @pgrzesik 👍 |
This PR introduces the following changes:
@serverless/utils
as a dependency@serverless/platform-client
to latest versionlogin
fromplatform-sdk
and replace it withlogin
functionality already implemented in plugingetLoggedInUser
,readConfigFile
,writeConfigFile
,refreshToken
andlogout
fromplatform-sdk
withutils
equivalentsAll of the above was tested with current testing suite + I've made a lot of "sanity" testing by hand locally.
Part of: #464