Partial migration from platform-sdk to platform-client
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing to draft for a moment - it seems there are a few tests failing only on CI 🤔 |
medikoo
reviewed
Mar 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 49.08% 49.79% +0.70%
==========================================
Files 90 90
Lines 2903 2922 +19
==========================================
+ Hits 1425 1455 +30
+ Misses 1478 1467 -11
Continue to review full report at Codecov.
|
|
Should be ready for a review now 👍 |
pgrzesik
force-pushed
the
migrate-from-platform-sdk-to-platform-client
branch
from
8ce3e2f
to
a0b0b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes migration from
platform-sdktoplatform-clientmethods with the exception ofDeploymentclass that will be migrated in subsequent PR (it's already quite big). I've tried to separate it into distinct commits as much as possible.It was all tested locally via CLI in addition to adjusting existing tests.
Closes: #533, #534, #535