Initial setup #1
Conversation
medikoo
force-pushed
the
initial-setup
branch
2 times, most recently
from
7c93448
to
ced2386
Compare
medikoo
force-pushed
the
initial-setup
branch
2 times, most recently
from
e78c1f8
to
2c2a9bd
Compare
- Prepare dedicated 'browser' and 'node' entry points - Ensure no environment unrelated rules are applied - Skip options that conflict with Prettier
It's more dev friendly to allow exceptions that Prettier produces
LICENSE
Outdated
| @@ -0,0 +1,15 @@ | |||
| ISC License | |||
There was a problem hiding this comment.
Not sure if we have a company-wide policy we follow here but usually new stuff we do uses Apache-2.
There was a problem hiding this comment.
Ok, I confirm with @ganeshvlrk on that
There was a problem hiding this comment.
@ganeshvlrk suggested we use MIT, to be consistent with other projects.
I've switched it to MIT then
| module.exports = { | ||
| extends: 'eslint:recommended', | ||
| env: { es6: true }, | ||
| parserOptions: { ecmaVersion: 2015 }, |
There was a problem hiding this comment.
Why this specific version and not something newer?
There was a problem hiding this comment.
It reflects Node.js v6 which we currently support in serverless project. Anything greater will allow syntax that may crash v6.
We may put greater version here, but then in serverless we should override it.
There was a problem hiding this comment.
Ok, that sounds reasonable. I was just asking because I'm not sure which projects use which Node.js version and maybe there's a tradeoff to be made here that we use newer version here and use v6 stuff only for the Framework (if that's the only project holding us back).
Hopefully we can get rid of Node.js 6 support soon.
Cross project ESLint & Prettier config
Initial version that reflects rules we rely on in serverless project, with following improvements:
eslint:recommendednode.js- Config for Node.js projectsbrowser.js- Config for Browser projectsCommitlint config
Currently experimental (practiced only in context of this repository), an attempt to rely on Convention Commits Convention, which will allow us to auto generate and improved CHANGELOG.md files.
See Commitlint and automation of release process for more info
Meta configuration for this repository
package.json