add unit test for Functions service

serverless · Sep 7, 2017 · 5899574 · 5899574
1 parent c8680af
commit 5899574
Show file tree

Hide file tree

Showing 4 changed files with 409 additions and 0 deletions.
diff --git a/functions/types.go → functions/function.go b/functions/types.go → functions/function.go
diff --git a/functions/functions_test.go b/functions/functions_test.go
@@ -0,0 +1,249 @@
+package functions
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/golang/mock/gomock"
+	"github.com/serverless/event-gateway/subscriptions/mock"
+	"github.com/serverless/libkv/store"
+	"github.com/stretchr/testify/assert"
+	"go.uber.org/zap"
+)
+
+func TestRegisterFunction(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(nil, errors.New("KV func not found"))
+	db.EXPECT().Put("testid", []byte(`{"functionId":"testid","provider":{"type":"http","url":"http://example.com"}}`), nil).Return(nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.RegisterFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example.com"}})
+
+	assert.Nil(t, err)
+}
+
+func TestRegisterFunction_ValidationError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.RegisterFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required fields for HTTP endpoint."})
+}
+
+func TestRegisterFunction_AlreadyExistsError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(nil, nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.RegisterFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example.com"}})
+
+	assert.Equal(t, err, &ErrAlreadyRegistered{ID: "testid"})
+}
+
+func TestRegisterFunction_PutError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(nil, errors.New("KV func not found"))
+	db.EXPECT().Put("testid", []byte(`{"functionId":"testid","provider":{"type":"http","url":"http://example.com"}}`), nil).Return(errors.New("KV put error"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.RegisterFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example.com"}})
+
+	assert.EqualError(t, err, "KV put error")
+}
+
+func TestUpdateFunction(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(&store.KVPair{Value: []byte(`{"functionId":"testid", "provider":{"type":"http","url":"http://example.com"}}`)}, nil)
+	db.EXPECT().Put("testid", []byte(`{"functionId":"testid","provider":{"type":"http","url":"http://example1.com"}}`), nil).Return(nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.UpdateFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example1.com"}})
+
+	assert.Nil(t, err)
+}
+
+func TestUpdateFunction_ValidationError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(&store.KVPair{Value: []byte(`{"functionId":"testid", "provider":{"type":"http","url":"http://example.com"}}`)}, nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.UpdateFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required fields for HTTP endpoint."})
+}
+
+func TestUpdateFunction_NotFoundError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(nil, errors.New("KV not found"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.UpdateFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example.com"}})
+
+	assert.Equal(t, err, &ErrNotFound{ID: "testid"})
+}
+
+func TestUpdateFunction_PutError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(&store.KVPair{Value: []byte(`{"functionId":"testid", "provider":{"type":"http","url":"http://example.com"}}`)}, nil)
+	db.EXPECT().Put("testid", []byte(`{"functionId":"testid","provider":{"type":"http","url":"http://example1.com"}}`), nil).Return(errors.New("KV put error"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.UpdateFunction(&Function{ID: "testid", Provider: &Provider{Type: HTTPEndpoint, URL: "http://example1.com"}})
+
+	assert.EqualError(t, err, "KV put error")
+}
+
+func TestGetFunction(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(&store.KVPair{Value: []byte(`{"functionId":"testid"}`)}, nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	function, _ := service.GetFunction(FunctionID("testid"))
+
+	assert.Equal(t, &Function{ID: "testid"}, function)
+}
+
+func TestGetFunction_NotFound(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Get("testid").Return(nil, errors.New("KV func not found"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.GetFunction(FunctionID("testid"))
+
+	assert.Equal(t, err, &ErrNotFound{"testid"})
+}
+
+func TestGetAllFunctions(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	kvs := []*store.KVPair{
+		&store.KVPair{Value: []byte(`{"functionId":"f1"}`)},
+		&store.KVPair{Value: []byte(`{"functionId":"f2"}`)},
+	}
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().List("").Return(kvs, nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	list, _ := service.GetAllFunctions()
+
+	assert.Equal(t, []*Function{{ID: FunctionID("f1")}, {ID: FunctionID("f2")}}, list)
+}
+
+func TestGetAllFunctions_ListError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().List("").Return([]*store.KVPair{}, errors.New("KV list err"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	_, err := service.GetAllFunctions()
+
+	assert.EqualError(t, err, "KV list err")
+}
+
+func TestDeleteFunction(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Delete("testid").Return(nil)
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	err := service.DeleteFunction(FunctionID("testid"))
+
+	assert.Nil(t, err)
+}
+
+func TestDeleteFunction_NotFound(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	db := mock.NewMockStore(ctrl)
+	db.EXPECT().Delete("testid").Return(errors.New("KV func not found"))
+	service := &Functions{DB: db, Log: zap.NewNop()}
+
+	err := service.DeleteFunction(FunctionID("testid"))
+
+	assert.EqualError(t, err, `Function "testid" not found.`)
+}
+
+func TestValidateFunction_AWSLambdaMissingRegion(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{ID: "id", Provider: &Provider{Type: AWSLambda, ARN: "arn::"}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required fields for AWS Lambda function."})
+}
+
+func TestValidateFunction_AWSLambdaMissingARN(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{ID: "id", Provider: &Provider{Type: AWSLambda, Region: "us-east-1"}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required fields for AWS Lambda function."})
+}
+
+func TestValidateFunction_HTTPMissingURL(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{ID: "id", Provider: &Provider{Type: HTTPEndpoint}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required fields for HTTP endpoint."})
+}
+
+func TestValidateFunction_MissingID(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{Provider: &Provider{Type: HTTPEndpoint}})
+
+	assert.Equal(t, err, &ErrValidation{"Key: 'Function.ID' Error:Field validation for 'ID' failed on the 'required' tag"})
+}
+
+func TestValidateFunction_EmulatorMissingURL(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{ID: "id", Provider: &Provider{Type: Emulator}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required field emulatorURL for Emulator function."})
+}
+
+func TestValidateFunction_EmulatorMissingAPIVersion(t *testing.T) {
+	service := &Functions{Log: zap.NewNop()}
+
+	err := service.validateFunction(&Function{ID: "id", Provider: &Provider{Type: Emulator, EmulatorURL: "http://example.com"}})
+
+	assert.Equal(t, err, &ErrValidation{"Missing required field apiVersion for Emulator function."})
+}
diff --git a/functions/mock/mock.go b/functions/mock/mock.go
@@ -0,0 +1,3 @@
+//go:generate mockgen -package mock -destination ./store.go github.com/docker/libkv/store Store
+
+package mock