Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config API should return 409 Conflict when resource already exists #465

Closed
mthenw opened this issue Jun 22, 2018 · 2 comments
Closed

Config API should return 409 Conflict when resource already exists #465

mthenw opened this issue Jun 22, 2018 · 2 comments
Labels
good first issue
Milestone
0.10 -- Reliabili...

Comments

@mthenw
Copy link
Contributor

mthenw commented Jun 22, 2018

It applies to all resources: functions, subscriptions, event types, cors.
@mthenw mthenw added this to the 1.0.0 milestone Jun 22, 2018
baniol added a commit to baniol/event-gateway that referenced this issue Jun 22, 2018
@baniol
Add 409 return status code to Config API resources (serverless#465)
8d39694
@baniol
Copy link
Contributor

baniol commented Jun 22, 2018

While working on a PR, I've noticed there's no test for createSubscription in httpapi_test.go. Should I add one?

@mthenw
Copy link
Contributor Author

mthenw commented Jun 25, 2018

Hey @baniol,

thanks for taking care of that. Would be great if you could also add tests for createSubscription.

@mthenw mthenw closed this as completed in 5e02910 Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
0.10 -- Reliability and Monitoring
Development

No branches or pull requests
2 participants
@baniol @mthenw