Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Path field support for async subscriptions #326

Merged
merged 13 commits into from
Sep 26, 2017
Merged

Adding Path field support for async subscriptions #326

merged 13 commits into from
Sep 26, 2017

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Sep 25, 2017

What did you implement:

How did you implement it:

This PR allows creating async subscription with "path" field specified. It allows creating "buckets" for events with the same type. It can be used to handle multiple teams, services under one EG instance.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped

Is this ready for review?: YES
Is it a breaking change?: YES

@mthenw mthenw merged commit 311b2bf into master Sep 26, 2017
@mthenw mthenw deleted the spaces branch September 26, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant