Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update running-locally.md #386

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Update running-locally.md #386

merged 1 commit into from
Mar 15, 2018

Conversation

paulxuca
Copy link
Contributor

Missing the repository on the 2 docker related commands :)

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@paulxuca
Update running-locally.md
238078e 
Missing the repository on the 2 docker related commands :)
@mthenw
Copy link
Contributor

mthenw commented Mar 15, 2018 •
edited
Loading

Thanks for that @paulxuca!

@mthenw mthenw merged commit cd14c40 into serverless:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulxuca @mthenw