Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis provider #392

Merged
merged 18 commits into from
Mar 19, 2018
Merged

Kinesis provider #392

merged 18 commits into from
Mar 19, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Mar 19, 2018

This PR add new provider: AWS Kinesis. It's a new type of functions -- connector. It takes incoming event and puts it into Kinesis stream.

@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #392 into master will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage    56.8%   56.87%   +0.07%     
==========================================
  Files          24       25       +1     
  Lines        1389     1433      +44     
==========================================
+ Hits          789      815      +26     
- Misses        555      572      +17     
- Partials       45       46       +1
Impacted Files Coverage Δ
providers/awskinesis/awskinesis.go 50% <50%> (ø)
router/router.go 51.32% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172a76e...40761f5. Read the comment docs.

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthenw mthenw merged commit d48736a into master Mar 19, 2018
@mthenw mthenw deleted the kinesis-provider branch March 19, 2018 13:42
@alexdebrie alexdebrie mentioned this pull request Mar 20, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants