Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup error messages and provide consistency in error reporting #396

Merged
merged 3 commits into from
Mar 22, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Mar 22, 2018

No description provided.

@mthenw mthenw requested a review from RaeesBhatti March 22, 2018 07:53
@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #396 into master will decrease coverage by 0.03%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   56.59%   56.55%   -0.04%     
==========================================
  Files          25       24       -1     
  Lines        1433     1434       +1     
==========================================
  Hits          811      811              
- Misses        576      577       +1     
  Partials       46       46
Impacted Files Coverage Δ
httpapi/httpapi.go 35.19% <0%> (-0.6%) ⬇️
function/errors.go 0% <0%> (ø) ⬆️
providers/http/http.go 70% <50%> (ø) ⬆️
providers/awskinesis/awskinesis.go 50% <66.66%> (ø) ⬆️
providers/awslambda/awslambda.go 41.17% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d923f...98481e8. Read the comment docs.

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mthenw mthenw merged commit bf66945 into master Mar 22, 2018
@mthenw mthenw deleted the cleanup-errors branch March 22, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants