Handle +json Content-Type in accordance with RFC6839 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=========================================
+ Coverage 63.85% 63.9% +0.04%
=========================================
Files 29 29
Lines 1649 1651 +2
=========================================
+ Hits 1053 1055 +2
Misses 553 553
Partials 43 43
Continue to review full report at Codecov.
|
mthenw
reviewed
Apr 27, 2018
| @@ -92,6 +92,26 @@ var newTests = []struct { | |||
| Data: "test", | |||
| }, | |||
| }, | |||
| { | |||
| // valid CloudEvent with application/cloudevents+json Content-Type | |||
There was a problem hiding this comment.
@alexdebrie should we accept CloudEvents with application/json content type?
There was a problem hiding this comment.
@mthenw Yea, I think we should. Not strictly according to CloudEvents spec, but 'be liberal in what you accept'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Handles
*+jsonContent-Types in accordance with RFC6839. This is important for CloudEvents interop, which may be sent inapplication/cloudevents+jsonformat.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO