Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating sync subscription for the same path and different method… #468

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 25, 2018

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #468   +/-   ##
======================================
  Coverage    68.5%   68.5%           
======================================
  Files          34      34           
  Lines        2137    2137           
======================================
  Hits         1464    1464           
  Misses        612     612           
  Partials       61      61
Impacted Files Coverage Δ
libkv/subscription.go 88.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9da41...d1b5df7. Read the comment docs.

@mthenw mthenw merged commit 42350ff into master Jun 25, 2018
@mthenw mthenw deleted the fix-sync branch June 25, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant