Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting existing routes with new route on / path #472

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 27, 2018

There was a bug allowing causing overwriting existing route with new route on root / level.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@mthenw mthenw changed the title Fix defining multiple subscriptions on root path Fix overwriting existing routes with new route on / path Jun 27, 2018
@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #472 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   70.78%   70.71%   -0.07%     
==========================================
  Files          35       35              
  Lines        2163     2165       +2     
==========================================
  Hits         1531     1531              
- Misses        570      571       +1     
- Partials       62       63       +1
Impacted Files Coverage Δ
libkv/subscription.go 88.75% <100%> (ø) ⬆️
internal/pathtree/tree.go 95.23% <100%> (-1.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e02910...add6032. Read the comment docs.

@mthenw mthenw merged commit a0794b2 into master Jun 27, 2018
@mthenw mthenw deleted the fix-root branch June 27, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant