Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path creation for hosted version #491

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix path creation for hosted version #491

merged 1 commit into from
Jul 24, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 24, 2018

This PR prevents from creating wrong path for system events in case of hosted version called via IP.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: NO

@mthenw mthenw requested a review from sebito91 July 24, 2018 21:10
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #491 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #491      +/-   ##
========================================
+ Coverage   70.97%    71%   +0.02%     
========================================
  Files          37     37              
  Lines        2188   2190       +2     
========================================
+ Hits         1553   1555       +2     
  Misses        572    572              
  Partials       63     63
Impacted Files Coverage Δ
router/path.go 100% <100%> (ø) ⬆️
router/path_hosted.go 85.71% <100%> (+2.38%) ⬆️
router/router.go 64.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfd936...63fde79. Read the comment docs.

Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to simplify the extractedPath, nicely done. I like the test too.

@mthenw mthenw merged commit 08b8053 into master Jul 24, 2018
@mthenw mthenw deleted the fix-path-hosted branch July 25, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants