Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system events recursive triggering #495

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Fix system events recursive triggering #495

merged 1 commit into from
Aug 2, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Aug 2, 2018

What did you implement:

Bug fix for triggering system events by other system events.

How did you implement it:

System events don't emit system events.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: NO

@mthenw mthenw requested a review from sebito91 August 2, 2018 16:31
@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #495 into master will decrease coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #495     +/-   ##
=========================================
- Coverage    71.2%   71.01%   -0.2%     
=========================================
  Files          37       37             
  Lines        2195     2201      +6     
=========================================
  Hits         1563     1563             
- Misses        571      575      +4     
- Partials       61       63      +2
Impacted Files Coverage Δ
router/router.go 63.66% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb79ad3...1a64cdb. Read the comment docs.

Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mthenw mthenw merged commit 8373e92 into master Aug 2, 2018
@mthenw mthenw deleted the fix-cycle branch August 2, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants