Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for bluebird, is there? #61

Closed
kaihendry opened this issue Jan 18, 2017 · 1 comment · Fixed by #74
Closed

No need for bluebird, is there? #61

kaihendry opened this issue Jan 18, 2017 · 1 comment · Fixed by #74

Comments

@kaihendry
Copy link
Contributor

https://github.com/serverless/examples/blob/master/aws-node-fetch-file-and-store-in-s3/handler.js#L5
https://twitter.com/kaihendry/status/821565738053931008
christophgysin added a commit to christophgysin/serverless-examples that referenced this issue Feb 6, 2017
@christophgysin
remove bluebird dependency
ffb6616 
fixes serverless#61
@christophgysin christophgysin mentioned this issue Feb 6, 2017
Merged
@DavidWells
Copy link
Contributor

Hmmm very good question.

For node 0.x yes. For node 4+ no =)

Updated the example

@DavidWells DavidWells reopened this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove bluebird dependency christophgysin/serverless-examples
2 participants
@DavidWells @kaihendry