-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript express example #577
Add typescript express example #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hoseungjang, it looks good, however, as I'm not expert on Typescript, I'll see if we can get another review. Also, please see a few of my comments
Thank you @hoseungjang - I believe it might be a bit better if you'd move your example to your own repository and list it under |
Hi @pgrzesik |
Sure @hoseungjang - as you're the only author of this example, it feels to me that it belongs more into |
Thank you for answer @pgrzesik . |
Yes, you should add it to the mentioned file. You can totally do that as a part of this PR. Thank you 🙇 |
Hi @pgrzesik ! |
Thank you @hoseungjang - I've forgot that the README has to be updated manually, sorry about that. Could you run Thanks 🙇 |
Thank you @pgrzesik . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hoseungjang 🙇
Hi. I added a pretty simple express application example with typescript.
Thanks!