-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add aws-node-sqs-worker
template
#585
Conversation
1ec39fd
to
b44d9a6
Compare
b44d9a6
to
bb1a034
Compare
aws-node-sqs-worker/handler.js
Outdated
console.log("Message Body: ", record.body); | ||
} | ||
} catch (error) { | ||
console.log(error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why errors are caught and logged ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point - initially I've added that to prevent retrying invalid messages over and over but I've decided to add DLQ to SQS queue but forgot to remove this - should be changed now
bb1a034
to
d778b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Introduces a new
aws-node-sqs-worker
template