Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add aws-node-sqs-worker template #585

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Mar 8, 2021

Introduces a new aws-node-sqs-worker template

@pgrzesik pgrzesik force-pushed the add-aws-node-sqs-worker-example branch from 1ec39fd to b44d9a6 Compare March 8, 2021 12:31
@pgrzesik pgrzesik self-assigned this Mar 8, 2021
@pgrzesik pgrzesik force-pushed the add-aws-node-sqs-worker-example branch from b44d9a6 to bb1a034 Compare March 8, 2021 15:50
@pgrzesik pgrzesik requested a review from medikoo March 8, 2021 16:03
console.log("Message Body: ", record.body);
}
} catch (error) {
console.log(error);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why errors are caught and logged ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great point - initially I've added that to prevent retrying invalid messages over and over but I've decided to add DLQ to SQS queue but forgot to remove this - should be changed now

@pgrzesik pgrzesik force-pushed the add-aws-node-sqs-worker-example branch from bb1a034 to d778b18 Compare March 8, 2021 19:08
@pgrzesik pgrzesik requested a review from medikoo March 8, 2021 19:21
Copy link

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik merged commit adf3fb1 into master Mar 9, 2021
@pgrzesik pgrzesik deleted the add-aws-node-sqs-worker-example branch March 9, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants