Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor guidelines #5

Merged
merged 4 commits into from May 22, 2017
Merged

Add contributor guidelines #5

merged 4 commits into from May 22, 2017

Conversation

rupakg
Copy link
Contributor

@rupakg rupakg commented May 17, 2017

[#6]

@ac360 I want your contributions! Hope this is a good starting point.

/cc @worldsoup @brianneisler @DavidWells

@rupakg rupakg added this to In Progress in Guide May 17, 2017
@rupakg rupakg moved this from In Progress to PR Opened in Guide May 17, 2017
@rupakg rupakg mentioned this pull request May 17, 2017
@worldsoup
Copy link

great start...might want @ac360 to take a look at those definitions if he hasn't already

@rupakg
Copy link
Contributor Author

rupakg commented May 18, 2017

@worldsoup terminology guide picked up from @brianneisler. See [Issue #4]

@brianneisler
Copy link

brianneisler commented May 19, 2017

@rupakg thanks for bringing that file over. @ac360 and I had a discussion a little while ago about removing the "Serverless ..." from the naming conventions for anything that is not specifically a Serverless product. So pretty much everything except Serverless Platform, Serverless Framework and Serverless Gateway. This might be good timing to finally make those modifications before this gets merged.

@rupakg
Copy link
Contributor Author

rupakg commented May 22, 2017

@brianneisler @ac360 Do you think "Serverless Service" also falls into the above category? Since its definition is tied to the 'serverless.yml' and will have facets that will closely relate to the framework and the platform, like decorators/conventions that will expose them as 'public consumable" services to the platform.

@rupakg rupakg merged commit ba6b719 into master May 22, 2017
@rupakg rupakg deleted the guide-4 branch May 22, 2017 18:56
@rupakg rupakg moved this from PR Opened to Merged in Guide May 22, 2017
@rupakg rupakg removed this from Done in Guide May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants