Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reliability of integration tests #58

Merged
merged 2 commits into from
May 26, 2022
Merged

Fix reliability of integration tests #58

merged 2 commits into from
May 26, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 26, 2022

Addresses two recent fails:

Fails happened because we started to process reports when just metrics report was read from S3 bucket.

This patch ensures we do not move to processing until there's also traces and final metrics report

@medikoo medikoo self-assigned this May 26, 2022
@medikoo medikoo requested a review from Danwakeem May 26, 2022 16:09
Copy link
Contributor

@Danwakeem Danwakeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice 👍 I guess sometimes it was producing all the reports fast enough and sometimes it wasn't?

@medikoo medikoo merged commit 1d80c73 into main May 26, 2022
@medikoo medikoo deleted the 0526-fix-tests branch May 26, 2022 16:11
hev pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants