Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated publishing script and only run tag on the main repo, not forks #665

Merged
merged 5 commits into from May 16, 2023

Conversation

gligorkot
Copy link
Collaborator

What did you implement:

When I merged the master branch this started failing in my repo, so adding this to only run the tag on the main repo, not on forks

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@gligorkot gligorkot requested a review from medikoo May 15, 2023 21:11
medikoo
medikoo previously approved these changes May 16, 2023
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gligorkot please follow up with merging without my reviews :)

@gligorkot gligorkot mentioned this pull request May 16, 2023
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not perfectly familiar with this project (I personally didn't work on it), still it looks ok to me

@gligorkot gligorkot changed the title Only run tag if new version on the main repo, not on forks fix: Updated publishing script and only run tag on the main repo, not forks May 16, 2023
@gligorkot gligorkot merged commit 1caebed into serverless:master May 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants