Fix Unexpected token : in JSON #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the deployment itself was legitimately failing,
but the error handling itself failed.
Specifically, I noticed that the error being thrown was unnecessarily
hiding the actual error, which obfuscated the real issue. The real
issue was that the error message was expected to return valid JSON,
but it was pseudo-JSON instead (no surrounding `{}`). By removing
the redundant JSON.stringify(JSON.parse(...)) wrapping of the message
I was able to see the actual issue in my case:
> "/httpsTrigger/url": domain: validation; keyword: type; message: instance does not match any allowed primitive type; allowed: ["string"]; found: "object"
which allowed me to realize that what I had done in the past with
AWS Lambda was not valid for GCP Cloud Functions (specifically
specifying the HTTP event with a method and cors support).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the deployment itself was legitimately failing, but the error handling itself failed.
Specifically, I noticed that the error being thrown was unnecessarily hiding the actual error, which obfuscated the real issue. The real issue was that the error message was expected to return valid JSON, but it was pseudo-JSON instead (no surrounding
{}). By removing the redundant JSON.stringify(JSON.parse(...)) wrapping of the message I was able to see the actual issue in my case:which allowed me to realize that what I had done in the past with AWS Lambda was not valid for GCP Cloud Functions (specifically specifying the HTTP event with a method and cors support).
Closes #78