Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there's no property location in cloud function #204

Conversation

ishallbethat
Copy link

I used version 2.4.2 of serverless-google-cloudfunctions.
First time deployment with it is fine.
Second time i got below error.
{"ResourceType":"gcp-types/cloudfunctions-v1:projects.locations.functions","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"message":"Invalid JSON payload received. Unknown name \"location\" at 'function': Cannot find field.","status":"INVALID_ARGUMENT","details":[{"@type":"type.googleapis.com/google.rpc.BadRequest","fieldViolations":[{"field":"function","description":"Invalid JSON payload received. Unknown name \"location\" at 'function': Cannot find field."}]}],"statusMessage":"Bad Request","requestPath":"https://cloudfunctions.googleapis.com/v1/projects/<project name>/locations/us-central1/functions/<function name>","httpMethod":"PATCH"}}
I don't see "location" as property in cloud function. See doc
https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions
So i raise this PR to fix this.

@ishallbethat
Copy link
Author

unit test has passed and also coverage test.
@medikoo @mather Can please take a look approve and merge ?

@ishallbethat
Copy link
Author

it's already applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants