Add some tests and change code style as requested #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all, maybe I need to expand the explanation more. This is a continuation of pull request #243 which has not been merged due to some testing issues. I added those testing here and hopefully those are enough (if there were anything missing please give inputs). The ingress and egress option is useful since when we are using those and redeploy the serverless without these feature to GCF, the ingress and egress config will be overwritten. Hopefully this feature can make into the main repo since without it changing the ingress and egress after deployment in GCP console is inefficient (and defeat the purpose of using serverless framework I guess?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, hope this helps. I also need this function so I try to change the code style as requested and add some test for the coverage and get it works in my travis ci and coveralls. Would be glad if this can make to the main repo.