Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for separate ingress class and ingress names. #181

Merged

Conversation

MPratley
Copy link
Contributor

@MPratley MPratley commented Aug 7, 2019

This PR lets users optionally specify an ingress name alongside the class, with the following syntax:

provider:
  name: kubeless
  ingress: 
    class: "azure/application-gateway"
    name: "appgw" # <- New!

This is necessary to support Azure's Application Gateway Ingress Controller (AGIC), as its class azure/application-gateway contains a /, which is an illegal character in annotation names.

See here for an example of the AGIC class

And here for an example of the (different) name AGIC has in annotations

Copy link
Collaborator

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the example and the patch!

@andresmgot
Copy link
Collaborator

@MPratley Do you mind bumping the version of the package so it gets automatically released?

@MPratley
Copy link
Contributor Author

MPratley commented Aug 7, 2019

@MPratley Do you mind bumping the version of the package so it gets automatically released?

@andresmgot done 👍. Thanks for the speedy approval! : )

@MPratley
Copy link
Contributor Author

MPratley commented Aug 7, 2019

As a semi-related aside, I put a documentation PR into the serverless repo serverless/serverless#6513

Copy link
Collaborator

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you :)

@andresmgot andresmgot merged commit 73a6f4f into serverless:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants