Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of invoke local related lifecycle hook #258

Merged
merged 1 commit into from Nov 10, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 9, 2021

Currently when invoke local is run with --watch option, command resolves instantly, signalling to the Framework that invocation ended, while watching remains to be in progress.

This patch ensures that the command doesn't resolve internally until the watch is either stopped manually or crashes

@medikoo medikoo added the bug label Nov 9, 2021
@medikoo medikoo self-assigned this Nov 9, 2021
Copy link
Contributor

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, if it's just that simple then that's awesome!

@medikoo medikoo merged commit 378f3be into master Nov 10, 2021
@medikoo medikoo deleted the 1109-fix-promise-issue branch November 10, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants