override slimPatterns instead of appending

[bweigel]

closes #216

[dschep]

Update the documentation to reflect that this option no longer adds, but overrides the slim pattern https://github.com/UnitedIncome/serverless-python-requirements#custom-removal-patterns

[bweigel]

@dschep I added a new option slimPatternsAppendDefaults, which defaults to true. This keeps backwards compatibility and when set to false adds the possibility to overwrite the default patterns with just the custom patterns.

[dschep]

Looks great! Think you could add some test coverage too? Probably easiest to add to the node tests in test.js rather than dealing with bats. run node test.js to run them.

i like the new way of doing it

[bweigel]

I'll look into the tests later. I am not very knowledgable when it comes to node & testing, so I'll have to look into it.

[dschep]

don't worry if you can't figure it out. just let me know and i'll take care of it.

[dschep]

one more thing, could you run npm run format and commit the changes & push. Thanks :)

[bweigel]

I have migrated the tests from bats to test.js. However, I have not implemented checks for Docker and I guess some of these tests fail, because docker is missing in the AppVeyor CI system.

[bweigel]

@dschep do you have some clue or hints on how to deal with the failing tests (i.e. docker is missing in the AppVeyor CI system)?

I am guessing in bats these tests are always skipped via docker &> /dev/null || skip "docker not present". I don't know how to deal with that in the test.js-tests.

[dschep]

Here's a function to check if Docker can be used in JS & how to use it. Tthis should actually cover all the use cases that bats was checking for (meaning, docker is usable, not just present)

[bweigel]

sweet. thanks!

[dschep]

Looks great!