Skip to content

Commit

Permalink
refactor: Typos in schema (#8735)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dmitry Shirokov committed Jan 10, 2021
1 parent 847fa34 commit 2b7568a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions lib/plugins/aws/provider.js
Expand Up @@ -454,7 +454,7 @@ class AwsProvider {
},
awsLambdaTimeout: { type: 'integer', minimum: 1, maximum: 900 },
awsLambdaTracing: { anyOf: [{ enum: ['Active', 'PassThrough'] }, { type: 'boolean' }] },
awsLambdaVersionning: { type: 'boolean' },
awsLambdaVersioning: { type: 'boolean' },
awsLambdaVpcConfig: {
type: 'object',
properties: {
Expand Down Expand Up @@ -922,7 +922,7 @@ class AwsProvider {
type: 'array',
items: { $ref: '#/definitions/awsCfInstruction' },
},
versionFunctions: { $ref: '#/definitions/awsLambdaVersionning' },
versionFunctions: { $ref: '#/definitions/awsLambdaVersioning' },
websocketsApiName: { type: 'string' },
websocketsApiRouteSelectionExpression: { type: 'string' },
},
Expand Down Expand Up @@ -997,7 +997,7 @@ class AwsProvider {
tags: { $ref: '#/definitions/awsResourceTags' },
timeout: { $ref: '#/definitions/awsLambdaTimeout' },
tracing: { $ref: '#/definitions/awsLambdaTracing' },
versionFunction: { $ref: '#/definitions/awsLambdaVersionning' },
versionFunction: { $ref: '#/definitions/awsLambdaVersioning' },
vpc: { $ref: '#/definitions/awsLambdaVpcConfig' },
},
additionalProperties: false,
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/configSchemaExtensions/test-plugin.js
Expand Up @@ -54,9 +54,9 @@ class TestPlugin {
'existingComplexEvent',
{
properties: {
somePluginAdditionalComplexeEventProp: { type: 'string' },
somePluginAdditionalComplexEventProp: { type: 'string' },
},
required: ['somePluginAdditionalComplexeEventProp'],
required: ['somePluginAdditionalComplexEventProp'],
}
);

Expand Down
6 changes: 3 additions & 3 deletions test/unit/lib/classes/ConfigSchemaHandler/index.test.js
Expand Up @@ -146,7 +146,7 @@ describe('ConfigSchemaHandler', () => {
expect(existingEventDefinition.required).to.include('somePluginAdditionalEventProp');
});

it('should extend schema with defineFunctionEventProperties method on complexe event schema', async () => {
it('should extend schema with defineFunctionEventProperties method on complex event schema', async () => {
const serverless = await runServerless({
fixture: 'configSchemaExtensions',
cliArgs: ['info'],
Expand All @@ -165,9 +165,9 @@ describe('ConfigSchemaHandler', () => {
type: 'object',
properties: {
existingPropForObjectEventDefinition: { type: 'string' },
somePluginAdditionalComplexeEventProp: { type: 'string' },
somePluginAdditionalComplexEventProp: { type: 'string' },
},
required: ['somePluginAdditionalComplexeEventProp'],
required: ['somePluginAdditionalComplexEventProp'],
},
],
});
Expand Down
6 changes: 3 additions & 3 deletions test/unit/lib/plugins/aws/package/compile/functions.test.js
Expand Up @@ -1943,19 +1943,19 @@ describe('lib/plugins/aws/package/compile/functions/index.test.js', () => {
// Replacement for
// https://github.com/serverless/serverless/blob/d8527d8b57e7e5f0b94ba704d9f53adb34298d99/lib/plugins/aws/package/compile/functions/index.test.js#L1457-L1504
//
// Confirm on TrancingConfig property
// Confirm on TracingConfig property
// Confirm also on needed IAM policies
});

it.skip('TODO: should support `functions[].onError` as arn', () => {
// Replacment for
// Replacement for
// https://github.com/serverless/serverless/blob/d8527d8b57e7e5f0b94ba704d9f53adb34298d99/lib/plugins/aws/package/compile/functions/index.test.js#L774-L821
//
// Confirm on Function `DeadLetterConfig` property and on IAM policy statement being added
});

it.skip('TODO: should support `functions[].onError` as Ref', () => {
// Replacment for
// Replacement for
// https://github.com/serverless/serverless/blob/d8527d8b57e7e5f0b94ba704d9f53adb34298d99/lib/plugins/aws/package/compile/functions/index.test.js#L823-L863
// https://github.com/serverless/serverless/blob/d8527d8b57e7e5f0b94ba704d9f53adb34298d99/lib/plugins/aws/package/compile/functions/index.test.js#L951-L988
//
Expand Down

0 comments on commit 2b7568a

Please sign in to comment.