fix(AWS ALB): Ensure to log deprecation at initialization stage

serverless · Nov 3, 2020 · 3cf6449 · 3cf6449
1 parent 8b914e5
commit 3cf6449
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/lib/plugins/aws/package/compile/events/alb/index.js b/lib/plugins/aws/package/compile/events/alb/index.js
@@ -1,6 +1,7 @@
 'use strict';
 
 const BbPromise = require('bluebird');
+const _ = require('lodash');
 
 const validate = require('./lib/validate');
 const compileTargetGroups = require('./lib/targetGroups');
@@ -30,6 +31,18 @@ class AwsCompileAlbEvents {
 
     // TODO: Complete schema, see https://github.com/serverless/serverless/issues/8020
     this.serverless.configSchemaHandler.defineFunctionEvent('aws', 'alb', { type: 'object' });
+
+    if (
+      this.serverless.service.provider.name === 'aws' &&
+      _.values(_.get(this.serverless.service.provider.alb, 'authorizers') || {}).some(
+        ({ allowUnauthenticated }) => allowUnauthenticated != null
+      )
+    ) {
+      this.serverless._logDeprecation(
+        'AWS_ALB_ALLOW_UNAUTHENTICATED',
+        'allowUnauthenticated is deprecated, use onUnauthenticatedRequest instead'
+      );
+    }
   }
 }
 

diff --git a/lib/plugins/aws/package/compile/events/alb/lib/validate.js b/lib/plugins/aws/package/compile/events/alb/lib/validate.js
@@ -209,13 +209,6 @@ module.exports = {
     const hasAllowUnauthenticated = auth.allowUnauthenticated != null;
     const hasOnUnauthenticatedRequest = auth.onUnauthenticatedRequest != null;
 
-    if (hasAllowUnauthenticated) {
-      this.serverless._logDeprecation(
-        'AWS_ALB_ALLOW_UNAUTHENTICATED',
-        'allowUnauthenticated is deprecated, use onUnauthenticatedRequest instead'
-      );
-    }
-
     if (hasAllowUnauthenticated && !hasOnUnauthenticatedRequest) {
       auth.onUnauthenticatedRequest = auth.allowUnauthenticated ? 'allow' : 'deny';
     } else {