Skip to content

Commit

Permalink
refactor: Replace inquirer with @serverless/inquirer (#7729)
Browse files Browse the repository at this point in the history
  • Loading branch information
AhmedFat7y committed May 26, 2020
1 parent a60d2c7 commit 4724cb8
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 46 deletions.
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/index.js
@@ -1,6 +1,6 @@
'use strict';

const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const initializeService = require('./initializeService');
const setupAws = require('./setupAws');
const tabCompletion = require('./tabCompletion');
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/initializeService.js
Expand Up @@ -2,7 +2,7 @@

const { join } = require('path');
const chalk = require('chalk');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const createFromTemplate = require('../../utils/createFromTemplate');
const {
getConfigFilePath,
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/initializeService.test.js
Expand Up @@ -5,7 +5,7 @@ const { expect } = require('chai');
const sinon = require('sinon');
const { remove: rmDir, lstat } = require('fs-extra');
const runServerless = require('../../../tests/utils/run-serverless');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const configureInquirerStub = require('@serverless/test/configure-inquirer-stub');

const fixturesPath = join(__dirname, 'test/fixtures');
Expand Down
36 changes: 0 additions & 36 deletions lib/plugins/interactiveCli/inquirer.js

This file was deleted.

2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/setupAws.js
Expand Up @@ -2,7 +2,7 @@

const BbPromise = require('bluebird');
const chalk = require('chalk');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const awsCredentials = require('../aws/utils/credentials');
const { confirm } = require('./utils');
const openBrowser = require('../../utils/openBrowser');
Expand Down
4 changes: 2 additions & 2 deletions lib/plugins/interactiveCli/setupAws.test.js
Expand Up @@ -7,7 +7,7 @@ const sinon = require('sinon');
const BbPromise = require('bluebird');
const { remove: rmDir, lstat, outputFile: writeFile } = require('fs-extra');
const { resolveFileProfiles } = require('../aws/utils/credentials');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const configureInquirerStub = require('@serverless/test/configure-inquirer-stub');
const runServerless = require('../../../tests/utils/run-serverless');

Expand All @@ -25,7 +25,7 @@ const modulesCacheStub = {
openBrowserUrls.push(url);
}),
// Ensure to rely on same inquirer module that we mock in tests
[require.resolve('./inquirer')]: inquirer,
[require.resolve('@serverless/inquirer')]: inquirer,
};

describe('interactiveCli: setupAws', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/tabCompletion.js
Expand Up @@ -12,7 +12,7 @@ const muteConsoleLog = require('../../utils/log/muteConsoleLog');
const isTabTabCompletionSupported = require('../../utils/tabCompletion/isSupported');
const tabtabOptions = require('../../utils/tabCompletion/tabtabOptions');
const promptDisabledConfigPropertyName = require('../../utils/tabCompletion/promptDisabledConfigPropertyName');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');
const { confirm } = require('./utils');

BbPromise.promisifyAll(fs);
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/tabCompletion.test.js
Expand Up @@ -12,7 +12,7 @@ const BbPromise = require('bluebird');
const configUtils = require('../../utils/config');
const promptDisabledConfigPropertyName = require('../../utils/tabCompletion/promptDisabledConfigPropertyName');
const isTabCompletionSupported = require('../../utils/tabCompletion/isSupported');
const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');

const lifecycleHookNamesBlacklist = [
'before:interactiveCli:setupAws',
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/interactiveCli/utils.js
@@ -1,6 +1,6 @@
'use strict';

const inquirer = require('./inquirer');
const inquirer = require('@serverless/inquirer');

module.exports = {
confirm: (message, options = {}) => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -178,6 +178,7 @@
"@serverless/cli": "^1.4.0",
"@serverless/components": "^2.30.11",
"@serverless/enterprise-plugin": "^3.6.12",
"@serverless/inquirer": "^1.1.2",
"archiver": "^3.1.1",
"async": "^1.5.2",
"aws-sdk": "^2.680.0",
Expand All @@ -199,7 +200,6 @@
"globby": "^9.2.0",
"graceful-fs": "^4.2.4",
"https-proxy-agent": "^5.0.0",
"inquirer": "^6.5.2",
"is-docker": "^1.1.0",
"is-wsl": "^2.2.0",
"js-yaml": "^3.13.1",
Expand Down

0 comments on commit 4724cb8

Please sign in to comment.