fix: Recognize falsy values as CLI options defaults (#7071)

serverless · Dec 13, 2019 · 7e0e903 · 7e0e903
1 parent f9b6507
commit 7e0e903
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
@@ -623,7 +623,7 @@ class PluginManager {
 
   assignDefaultOptions(command) {
     _.forEach(command.options, (value, key) => {
-      if (value.default && (!this.cliOptions[key] || this.cliOptions[key] === true)) {
+      if (value.default != null && (!this.cliOptions[key] || this.cliOptions[key] === true)) {
         this.cliOptions[key] = value.default;
       }
     });

diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
@@ -1320,6 +1320,26 @@ describe('PluginManager', () => {
 
       expect(pluginManager.cliOptions.bar).to.equal(100);
     });
+
+    [0, '', false].forEach(defaultValue => {
+      it(`assigns valid falsy default value '${defaultValue} to empty options`, () => {
+        pluginManager.commands = {
+          foo: {
+            options: {
+              bar: {
+                required: true,
+                default: defaultValue,
+              },
+            },
+          },
+        };
+
+        const foo = pluginManager.commands.foo;
+        pluginManager.assignDefaultOptions(foo);
+
+        expect(pluginManager.cliOptions.bar).to.equal(defaultValue);
+      });
+    });
   });
 
   describe('#validateServerlessConfigDependency()', () => {