adds renamed variable for skipping renaming

serverless · Nov 4, 2016 · bd37e27 · bd37e27
1 parent 0b38b64
commit bd37e27
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/plugins/install/install.js b/lib/plugins/install/install.js
@@ -72,6 +72,7 @@ class Install {
     };
 
     const name = this.options.name || parsedGitHubUrl.repo;
+    const renamed = name !== parsedGitHubUrl.repo;
 
     // validate if given url is a valid GitHub url
     if (url.hostname !== 'github.com' || !parsedGitHubUrl.owner || !parsedGitHubUrl.repo) {
@@ -109,7 +110,7 @@ class Install {
       servicePath,
       { timeout: 30000, extract: true, strip: 1, mode: '755' }
     ).then(() => {
-      if (!name) {
+      if (!renamed) {
         return '';
       }
       return this.renameService(name, servicePath);

diff --git a/lib/plugins/install/tests/install.js b/lib/plugins/install/tests/install.js
@@ -85,7 +85,6 @@ describe('Install', () => {
       };
 
       return install.install().then(() => {
-        expect(downloadStub.calledOnce).to.equal(true);
         expect(downloadStub.args[0][0]).to.equal(`${install.options.url}/archive/master.zip`);
       });
     });