AWS Custom Resource Lambda still using NodeJS 14.x

[ashley-jisc]

Is there an existing issue for this?

• I have searched existing issues, it hasn't been reported yet

Use case description

This is effectively the same as #10432 with the exception that nodejs 14 is not EOL.

The custom resource lambda (*-custom-resource-apigw-cw-role) created automatically via serverless has a hardcoded runtime of "nodejs14.x":

serverless/lib/plugins/aws/customResources/index.js

When building our product with Serverless, we wish to have parity across our services when it comes to runtimes. We've upgraded to nodejs 16 but we still have a bunch of custom-resource-apigw-cw-role lambdas stuck at nodejs 14.

Proposed solution (optional)

• Upgrade it to node16
• Allow a CLI flag to override it on deployment

[medikoo]

@ashley-jisc PR is welcome!

[300LiterPropofol]

I think I have encountered something similar! I posted a discussion here #11364

But in my case the default version is nodejs12.x and I couldn't find anywhere to change. AWS is gonna stop nodejs12.x support so this becomes a bug for me. What is your serverless version?
Mine is

Framework Core: 2.59.0 (standalone)
Plugin: 5.4.4
SDK: 4.3.0
Components: 3.17.0

[ashley-jisc]

I think I have encountered something similar! I posted a discussion here #11364

But in my case the default version is nodejs12.x and I couldn't find anywhere to change. AWS is gonna stop nodejs12.x support so this becomes a bug for me. What is your serverless version? Mine is

Framework Core: 2.59.0 (standalone)
Plugin: 5.4.4
SDK: 4.3.0
Components: 3.17.0

They updated from nodejs12.x to nodejs14.x - I talk about it in my original post, and link the issue... ????

[ALOHACREPES345]

Maybe this issue is resolved by #11367.

But, if there is no special reason, I think it would be better that this Lambda also refers "runtime" in serverless.yml as well as other functions. This may let users to avoid upgrading serverless version due to this hardcorded runtime version.

If you agree, I'll try to work on it. @medikoo

[medikoo]

@ALOHACREPES345 I think it's safer to keep it fixed, to avoid unexpected compatibility issues

[ALOHACREPES345]

@medikoo
hmm... If changing fixed version like #11367 could be acceptable, changing to referring runtime can also be acceptable. Because it means same in terms of just changing the runtime version.

before

Runtime: 'nodejs14.x',

after

Runtime: providerConfig.runtime || 'nodejs14.x',
or
Runtime: awsProvider.getRuntime(),  

But I may have overlooked compatibility point of view, so I would follow your opinion. Thank you.