New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeJS updated to 16.x #11367
NodeJS updated to 16.x #11367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cagriatalay great thanks for addressing that. Still unfortunately unit tests also have to be updated, check CI fails
Great to see this is being fixed. I wonder when this patch will be merged and released? |
@300LiterPropofol we were not notified that this PR is ready for re-review, so it got stale. Nonetheless, we'll check it now. |
Codecov ReportBase: 85.85% // Head: 85.85% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #11367 +/- ##
=======================================
Coverage 85.85% 85.85%
=======================================
Files 314 314
Lines 13253 13253
=======================================
Hits 11378 11378
Misses 1875 1875
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cagriatalay !
@medikoo You're welcome sir, thanks for the opportunity. |
Super cool to see this is merged to main, I wonder whether this update, i.e., nodejs using 16.x, will be included in |
@300LiterPropofol It was already published |
Closes: #{#11359}