Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS updated to 16.x #11367

Merged
merged 2 commits into from Sep 19, 2022
Merged

NodeJS updated to 16.x #11367

merged 2 commits into from Sep 19, 2022

Conversation

cagriatalay
Copy link
Contributor

@cagriatalay cagriatalay commented Aug 31, 2022

Closes: #{#11359}

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cagriatalay great thanks for addressing that. Still unfortunately unit tests also have to be updated, check CI fails

@300LiterPropofol
Copy link

Great to see this is being fixed. I wonder when this patch will be merged and released?

@medikoo
Copy link
Contributor

medikoo commented Sep 19, 2022

@300LiterPropofol we were not notified that this PR is ready for re-review, so it got stale.

Nonetheless, we'll check it now.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 85.85% // Head: 85.85% // No change to project coverage 👍

Coverage data is based on head (51499f9) compared to base (9bb3f11).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11367   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         314      314           
  Lines       13253    13253           
=======================================
  Hits        11378    11378           
  Misses       1875     1875           
Impacted Files Coverage Δ
lib/plugins/aws/custom-resources/index.js 98.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cagriatalay !

@medikoo medikoo merged commit 93ce41e into serverless:main Sep 19, 2022
@cagriatalay
Copy link
Contributor Author

@medikoo You're welcome sir, thanks for the opportunity.

@300LiterPropofol
Copy link

Super cool to see this is merged to main, I wonder whether this update, i.e., nodejs using 16.x, will be included in npm i serverless package. Will it be included in the next release?

@medikoo
Copy link
Contributor

medikoo commented Oct 14, 2022

@300LiterPropofol It was already published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants