Lambda alias events

[rnielsen]

Most events were not using the lambda alias when calling the lambda when using the provisionedConcurrency or snapStart options, meaning these features weren't being used. I've created a new unit test alias.test.js which checks the following for all resources which have a reference to a provisionedConcurrency or snapStart lambda:

• Make sure the alias is configured in the ARN
• Make sure the alias is the DependsOn

Closes: #11662
Closes: #11246
Closes: #11484
Closes: #10764
Closes: #10167

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (8e244d5) 86.56% compared to head (e14947f) 86.60%.

❗ Current head e14947f differs from pull request most recent head 4bd7aaf. Consider uploading reports for the commit 4bd7aaf to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11788      +/-   ##
==========================================
+ Coverage   86.56%   86.60%   +0.04%     
==========================================
  Files         314      314              
  Lines       13127    13161      +34     
==========================================
+ Hits        11363    11398      +35     
+ Misses       1764     1763       -1     

Impacted Files	Coverage Δ
...kage/compile/events/api-gateway/lib/authorizers.js	100.00% <ø> (ø)
...ile/events/api-gateway/lib/method/authorization.js	100.00% <ø> (ø)
lib/plugins/aws/deploy-function.js	96.22% <100.00%> (+0.01%)	⬆️
lib/plugins/aws/package/compile/events/activemq.js	100.00% <100.00%> (ø)
...ws/package/compile/events/alb/lib/target-groups.js	100.00% <100.00%> (ø)
.../plugins/aws/package/compile/events/alexa-skill.js	96.29% <100.00%> (ø)
...ins/aws/package/compile/events/alexa-smart-home.js	100.00% <100.00%> (ø)
...age/compile/events/api-gateway/lib/method/index.js	100.00% <100.00%> (ø)
...ompile/events/api-gateway/lib/request-validator.js	98.07% <100.00%> (ø)
...ns/aws/package/compile/events/cloud-watch-event.js	97.77% <100.00%> (+0.05%)	⬆️
... and 19 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[medikoo]

@rnielsen great, thanks for addressing that. It looks impressive!

Still, please see my comment. I believe a lot of changes hare are not needed (and if they're needed, they're out of scope, and should be covered with different PR)

[medikoo]

@rnielsen again, that looks really good. I'm impressed.

I've proposed just one stylistic change, and can you also confirm on your side that integration tests are passing. See the instructions: https://github.com/serverless/serverless/tree/main/test#aws-integration-tests

[medikoo]

@rnielsen Thank you! I've proposed just one last stylistic update and we should be good to go

[medikoo]

Thank you @rnielsen !