-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm install pulling v4 breaking CI #12503
Comments
@LorenzoRogai sorry this impacted you, but the reason you are seeing issues is due to your install of v4 not being authenticated. You can go to our upgrade guide and read about setting an access key or a license key in your CICD pipeline. |
This comment was marked as abuse.
This comment was marked as abuse.
@LorenzoRogai Always pin to specific versions for all dependencies. You can pin to V3 by adding the version to your global install command:
Also fyi, esbuild is in V4 by default, allowing for native bundling and Typescript support.
Can you share more about your set-up here and the directory structure?
Looking into this one... |
Closing this since the original issue is resolved. Opening new issues to investigate the other problems raised here. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Now in our CI builds, even though we specify to use 3.38.0, version 4 is being installed. |
@kchecoBasis This is likely not possible. Something else is happening here that is causing V4 to be installed. Try |
@ac360 Will add npm ls -g once we clear sls config issues. We are currently setting our configs to use v4 without using the default esbuild functionality. In the near future, we will update them to use the default esbuild feature in our playground environment and observe time to deployment, bundling size, etc. Regarding v4 being installed, we have defined serverless@3.38.0 in our github actions workflow but somehow it is now being ignored. UPDATE: Seems like our team initiated a package build while changes to github actions had not been merged to our staging branch. Will confirm in a few minutes. UPDATE: The package workflow is not utilizing the updated command, we will debug on our end.
|
@kchecoBasis going off of those pictures it looks like the second one installs v3.38.0 correctly but the |
Are you certain it's a bug?
Is the issue caused by a plugin?
Are you using the latest v3 release?
Is there an existing issue for this?
Issue description
The "npm install serverless" command now pulls the v4 breaking all the CIs
was this announced? I read that the v4 is still in beta
This workflow now fails and it was working fine before
Service configuration (serverless.yml) content
N/A
Command name and used flags
N/A
Command output
Environment information
The text was updated successfully, but these errors were encountered: